Repository navigation
Conversation
- Register the event handler attributes already present in a text when it is set on the editor (they were ignored, so onCursorEnter:leave: never fired). - Let each event handler attribute register itself (registerInEditor:), so adding an onCursorEnter:leave: attribute no longer raises DNU #eventDispatcher on AlbTextCursorAttribute. - On cursor add, notify every event handler attribute of the text whether a cursor is inside it, so the leave action fires when the cursor moves out. - Add 7 tests in AlbTextEditorTest (protocol tests - cursor attributes). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tinchodias I do not know if this is good. Claude generated that and I tried to reduce to this but I'm not good enough into it. for now.